Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: switch to pathlib.Path in cvedb.py #1751

Merged
merged 2 commits into from
Jul 6, 2022
Merged

refactor: switch to pathlib.Path in cvedb.py #1751

merged 2 commits into from
Jul 6, 2022

Conversation

rhythmrx9
Copy link
Contributor

closes #1735

terriko
terriko approved these changes Jul 6, 2022
View reviewed changes
Copy link
Contributor

@terriko terriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. BTW I forgot to ask in our meeting, but how do you like pathdir? I'm used to reading os.path stuff enough that I don't find it a huge improvement except for the places where there used to be .join() constructions.

@terriko terriko merged commit 9bcdc1d into intel:main Jul 6, 2022
@rhythmrx9 rhythmrx9 deleted the path branch July 8, 2022 04:48
@rhythmrx9
Copy link
Contributor Author

Same for me, I just found it slightly better in some instances, nothing huge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@terriko terriko terriko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

refactor: switch to pathlib.path from os.path in cvedb.py
2 participants
@rhythmrx9 @terriko