Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix is_file call in test_scanner.py #1761

Merged
merged 1 commit into from
Jul 11, 2022
Merged

fix: fix is_file call in test_scanner.py #1761

merged 1 commit into from
Jul 11, 2022

Conversation

ffontaine
Copy link
Contributor

Parentheses are missing after is_file resulting in an error with LONG_TESTS=1 pytest if the package is not already in condensed-downloads since commit f03e885

Signed-off-by: Fabrice Fontaine fabrice.fontaine@orange.com

Parentheses are missing after is_file resulting in an error with
LONG_TESTS=1 pytest if the package is not already in condensed-downloads
since commit f03e885

Signed-off-by: Fabrice Fontaine <fabrice.fontaine@orange.com>
@ffontaine ffontaine changed the title test/test_scanner.py: fix download fix: fix is_file call in test_scanner.py Jul 8, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jul 8, 2022

Codecov Report

Merging #1761 (65ebbc6) into main (6c13a9d) will increase coverage by 2.33%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #1761      +/-   ##
==========================================
+ Coverage   83.84%   86.18%   +2.33%     
==========================================
  Files         307      308       +1     
  Lines        6581     6615      +34     
  Branches     1068     1071       +3     
==========================================
+ Hits         5518     5701     +183     
+ Misses        820      681     -139     
+ Partials      243      233      -10     
Flag Coverage Δ
longtests 86.18% <0.00%> (+2.33%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
test/test_scanner.py 75.18% <0.00%> (+12.78%) ⬆️
cve_bin_tool/nvd_api.py 75.20% <0.00%> (-8.80%) ⬇️
cve_bin_tool/available_fix/debian_cve_tracker.py 69.38% <0.00%> (-8.17%) ⬇️
test/test_requirements.py 0.00% <0.00%> (ø)
test/test_version.py 100.00% <0.00%> (ø)
cve_bin_tool/extractor.py 60.48% <0.00%> (+0.97%) ⬆️
cve_bin_tool/version_scanner.py 77.51% <0.00%> (+1.16%) ⬆️
cve_bin_tool/cvedb.py 85.08% <0.00%> (+1.75%) ⬆️
cve_bin_tool/cli.py 73.04% <0.00%> (+2.34%) ⬆️
cve_bin_tool/checkers/glibc.py 100.00% <0.00%> (+4.16%) ⬆️
... and 10 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Copy link
Contributor

@terriko terriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@terriko terriko merged commit f11a118 into intel:main Jul 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants