Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update database before merging #1765

Merged
merged 2 commits into from
Jul 11, 2022
Merged

fix: update database before merging #1765

merged 2 commits into from
Jul 11, 2022

Conversation

b31ngd3v
Copy link
Contributor

@b31ngd3v b31ngd3v commented Jul 11, 2022

i noticed a spike in the number of failed CIs, so i investigated a little and found out if there is no cached db to use, it was failing to create a db during the run, so i just moved the block of code that was handling db related tasks before the block of code that was handling merging.

image

@codecov-commenter
Copy link

Codecov Report

Merging #1765 (ff5c71e) into main (97eaef8) will increase coverage by 2.38%.
The diff coverage is 40.00%.

@@            Coverage Diff             @@
##             main    #1765      +/-   ##
==========================================
+ Coverage   83.79%   86.18%   +2.38%     
==========================================
  Files         308      308              
  Lines        6615     6615              
  Branches     1071     1071              
==========================================
+ Hits         5543     5701     +158     
+ Misses        829      681     -148     
+ Partials      243      233      -10     
Flag Coverage Δ
longtests 86.18% <40.00%> (+2.38%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cve_bin_tool/cli.py 73.04% <40.00%> (+2.34%) ⬆️
cve_bin_tool/nvd_api.py 75.20% <0.00%> (-8.80%) ⬇️
cve_bin_tool/extractor.py 60.48% <0.00%> (+0.97%) ⬆️
cve_bin_tool/version_scanner.py 77.51% <0.00%> (+1.16%) ⬆️
cve_bin_tool/cvedb.py 85.08% <0.00%> (+1.75%) ⬆️
cve_bin_tool/checkers/glibc.py 100.00% <0.00%> (+4.16%) ⬆️
cve_bin_tool/available_fix/debian_cve_tracker.py 69.38% <0.00%> (+6.12%) ⬆️
test/test_cli.py 88.84% <0.00%> (+8.92%) ⬆️
cve_bin_tool/available_fix/redhat_cve_tracker.py 80.35% <0.00%> (+8.92%) ⬆️
... and 7 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Copy link
Contributor

@terriko terriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ooh, thanks for the investigation! Hopefully this will help.

@terriko terriko merged commit fe2d5d9 into intel:main Jul 11, 2022
@b31ngd3v b31ngd3v deleted the fix_db branch July 11, 2022 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants