Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(checker): Added qemu checker #2460

Merged
merged 1 commit into from
Dec 21, 2022
Merged

feat(checker): Added qemu checker #2460

merged 1 commit into from
Dec 21, 2022

Conversation

metabiswadeep
Copy link
Contributor

Fixes #2000

Added qemu checker

@codecov-commenter
Copy link

codecov-commenter commented Dec 21, 2022

Codecov Report

Merging #2460 (c369176) into main (ab5c2fc) will increase coverage by 5.56%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2460      +/-   ##
==========================================
+ Coverage   77.79%   83.36%   +5.56%     
==========================================
  Files         581      583       +2     
  Lines        9679     9689      +10     
  Branches     1319     1319              
==========================================
+ Hits         7530     8077     +547     
+ Misses       1847     1287     -560     
- Partials      302      325      +23     
Flag Coverage Δ
longtests 82.81% <100.00%> (+5.94%) ⬆️
win-longtests 75.27% <100.00%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cve_bin_tool/checkers/__init__.py 95.55% <ø> (ø)
cve_bin_tool/checkers/qemu.py 100.00% <100.00%> (ø)
test/test_data/qemu.py 100.00% <100.00%> (ø)
cve_bin_tool/output_engine/console.py 97.60% <0.00%> (+1.59%) ⬆️
cve_bin_tool/cli.py 68.16% <0.00%> (+2.89%) ⬆️
cve_bin_tool/cve_scanner.py 81.39% <0.00%> (+3.48%) ⬆️
cve_bin_tool/version.py 100.00% <0.00%> (+5.88%) ⬆️
cve_bin_tool/output_engine/pdfbuilder.py 91.01% <0.00%> (+7.18%) ⬆️
test/test_cli.py 87.76% <0.00%> (+10.79%) ⬆️
cve_bin_tool/async_utils.py 94.48% <0.00%> (+11.03%) ⬆️
... and 6 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@terriko terriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! (Test fails on windows are unrelated, and I opened a separate issue to try to address those)

@terriko terriko merged commit 85be2b4 into intel:main Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New checker request: qemu
3 participants