Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve output of cve-scan github action for cve #2475

Merged
merged 3 commits into from
Jan 3, 2023
Merged

fix: improve output of cve-scan github action for cve #2475

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9843c0f
improve output of cve-scan github action for unexplored cve
ayushthe1 Dec 28, 2022
c65b1c9
Merge branch 'main' into branch5_gith_act
ayushthe1 Dec 28, 2022
85b43b3
change the assert message
ayushthe1 Dec 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion test/test_requirements.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,11 @@ def test_requirements():
with open(OUTPUT_JSON) as f:
output_json = json.load(f)
for entry in output_json:
assert entry["remarks"] in ["Mitigated", "Ignored"]
assert entry["remarks"] in [
"Mitigated",
"Ignored",
], f"Component {entry['product']} has a {entry['remarks']} potential CVE. "

# Disabled until we fix how ignored/mitigated issues are listed
# See https://github.com/intel/cve-bin-tool/issues/1752
# assert (
Expand Down