Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve libjpeg-turbo checker #2514

Merged
merged 1 commit into from
Jan 25, 2023

Conversation

ffontaine
Copy link
Contributor

@ffontaine ffontaine commented Jan 10, 2023

  • Add d.r.commander:libjpeg-turbo CPE ID and while at it fix a typo libjpg-turbo -> libjpeg-turbo
  • Drop LIBJPEG_([0-9]+\.[0-9]+\.?[0-9]?) pattern which will raise false positive with libjpeg.so.9.3.0 (i.e. libjpeg in version 9c)
    which contains LIBJPEG_9.0
  • Drop LIBJPEGTURBO_([0-9]+\.[0-9]+\.?[0-9]?) pattern which could also raise false positive with any applications linking with libjpeg-turbo
  • Add debian an openwrt test packages

Signed-off-by: Fabrice Fontaine fabrice.fontaine@orange.com

@ffontaine ffontaine force-pushed the fix-libjpeg-turbo-checker branch from 71ca0b6 to b532ee9 Compare January 10, 2023 12:37
@ffontaine ffontaine force-pushed the fix-libjpeg-turbo-checker branch from b532ee9 to f532242 Compare January 24, 2023 10:20
- Add d.r.commander:libjpeg-turbo CPE ID and while at it fix a typo
  libjpg-turbo -> libjpeg-turbo
- Drop "LIBJPEG_([0-9]+\.[0-9]+\.?[0-9]?)" pattern which will raise
  false positive with libjpeg.so.9.3.0 (i.e. libjpeg in version 9c)
  which contains LIBJPEG_9.0
- Drop "LIBJPEGTURBO_([0-9]+\.[0-9]+\.?[0-9]?)" pattern which could also
  raise false positive with any applications linking with libjpeg-turbo
- Add debian an openwrt test packages

Signed-off-by: Fabrice Fontaine <fabrice.fontaine@orange.com>
@ffontaine ffontaine force-pushed the fix-libjpeg-turbo-checker branch from f532242 to 8f9ba52 Compare January 24, 2023 10:42
@codecov-commenter
Copy link

Codecov Report

Merging #2514 (8f9ba52) into main (caa5612) will increase coverage by 0.41%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2514      +/-   ##
==========================================
+ Coverage   82.95%   83.37%   +0.41%     
==========================================
  Files         594      594              
  Lines        9811     9811              
  Branches     1344     1344              
==========================================
+ Hits         8139     8180      +41     
+ Misses       1333     1301      -32     
+ Partials      339      330       -9     
Flag Coverage Δ
longtests 82.90% <100.00%> (+0.41%) ⬆️
win-longtests 75.35% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
test/test_data/libjpeg_turbo.py 100.00% <ø> (ø)
cve_bin_tool/checkers/libjpeg_turbo.py 100.00% <100.00%> (ø)
cve_bin_tool/cli.py 68.16% <0.00%> (+0.32%) ⬆️
cve_bin_tool/data_sources/nvd_source.py 63.07% <0.00%> (+4.56%) ⬆️
cve_bin_tool/data_sources/gad_source.py 88.12% <0.00%> (+18.12%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@terriko terriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@terriko terriko merged commit 4f1125a into intel:main Jan 25, 2023
@ffontaine ffontaine deleted the fix-libjpeg-turbo-checker branch January 25, 2023 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants