Let 'cve-bin-tool --version' return success #2524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raboof
commented
Jan 11, 2023
| # Check command line parameters - wrong option | ||
| with pytest.raises(SystemExit) as e: | ||
| main(["cve-bin-tool", "-S", "ALL", self.tempdir]) | ||
| assert e.value.args[0] == ERROR_CODES[SystemExit] | ||
| assert e.value.args[0] == 2 |
There was a problem hiding this comment.
It's a fine line between 'make tests DRY and human-readable' and 'avoid depending on internals in tests'.
In this case I think this is an improvement, since SystemExit may carry various exit codes.
Previously, `cve-bin-tool --version` returned an error code of '2', as if it was an invalid argument. With this change, it returns successfully, consistent with standard argparse behavior.
raboof
force-pushed
the
show-version-without-error-code
branch
from
6460af7 to
6f9bd56
Compare
terriko
approved these changes
Jan 11, 2023
There was a problem hiding this comment.
Thanks for spotting this -- I'd never had reason to check the return code on --version but it's definitely not correct to have it return a failure code.
I'm sure someone's going to find this confusing in the future but I agree with you that there's not exactly a best answer, so let's go with this and we can always iterate to improve if we think of something better later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
cve-bin-tool --versionreturned an error code of '2', as if it was an invalid argument.With this change, it returns successfully, consistent with standard argparse behavior.