fix: improve dhclient checker and add dhcpd checker #2642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terriko
approved these changes
Feb 6, 2023
terriko
requested changes
Feb 6, 2023
There was a problem hiding this comment.
Whoops, hit approve too soon.
FAILED test/test_scanner.py::TestScanner::test_version_in_package[http://archive.ubuntu.com/ubuntu/pool/universe/b/busybox/-busybox_1.18.5-1ubuntu4_amd64.deb-busybox-1.18.5-other_products63] - AssertionError: dhcp found in busybox_1.18.5-1ubuntu4_amd64.deb. If that's expected, make sure to add dhcp to the expected list of other_products.
assert 'dhcp' not in {'busybox', 'dhcp', 'dhcpd'}
I guess we can probably just add dhcp to other_products in the dhcpd tests to fix this. Although, as I said, I wouldn't be adverse to combining the checkers given the way the source works here.
- isc:dhcp CPE ID is not only related to ISC DHCP client but also to ISC DHCP server as both components have the same source code - Drop second pattern which is not used to find version in RPM - Add debian and OpenWRT test packages as well as additional signatures - Add dhcpd checker Signed-off-by: Fabrice Fontaine <fabrice.fontaine@orange.com>
ffontaine
force-pushed
the
add-dhcp-checker
branch
from
d2cf549 to
325b40d
Compare
|
Indeed, ISC DHCP client and server share a part of their source code as well as isc:dhcp CPE ID. However, they also have different signatures and additional dedicated CPE IDs (isc:dhcp_client and isc:dhcpd). So, I think we should keep checkers separate. |
Codecov Report
@@ Coverage Diff @@
## main #2642 +/- ##
==========================================
- Coverage 82.72% 82.65% -0.08%
==========================================
Files 634 636 +2
Lines 9970 9980 +10
Branches 1334 1334
==========================================
+ Hits 8248 8249 +1
- Misses 1383 1388 +5
- Partials 339 343 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
terriko
approved these changes
Feb 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Fabrice Fontaine fabrice.fontaine@orange.com