Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Any type in config.py #2670

Merged
merged 2 commits into from
Feb 9, 2023
Merged

fix: Any type in config.py #2670

merged 2 commits into from
Feb 9, 2023

Conversation

Rexbeast2
Copy link
Contributor

fixes #2393

@codecov-commenter
Copy link

codecov-commenter commented Feb 8, 2023

Codecov Report

Merging #2670 (9392644) into main (0e5ce5a) will increase coverage by 5.70%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2670      +/-   ##
==========================================
+ Coverage   76.99%   82.69%   +5.70%     
==========================================
  Files         636      638       +2     
  Lines        9980     9991      +11     
  Branches     1334     1334              
==========================================
+ Hits         7684     8262     +578     
+ Misses       1994     1388     -606     
- Partials      302      341      +39     
Flag Coverage Δ
longtests 77.04% <100.00%> (+0.05%) ⬆️
win-longtests 80.18% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cve_bin_tool/config.py 100.00% <100.00%> (ø)
cve_bin_tool/nvd_api.py 18.32% <0.00%> (ø)
test/test_requirements.py 0.00% <0.00%> (ø)
cve_bin_tool/egg_updater.py 77.77% <0.00%> (ø)
cve_bin_tool/helper_script.py 82.05% <0.00%> (ø)
cve_bin_tool/checkers/__init__.py 95.55% <0.00%> (ø)
cve_bin_tool/checkers/rauc.py 100.00% <0.00%> (ø)
test/test_data/rauc.py 100.00% <0.00%> (ø)
cve_bin_tool/output_engine/console.py 93.60% <0.00%> (+0.79%) ⬆️
cve_bin_tool/merge.py 80.64% <0.00%> (+0.80%) ⬆️
... and 15 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@terriko terriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Getting an error:

TypeError: 'type' object is not subscriptable

You probably need a from __future__ import annotations up at the very top of the file to handle the types on older python versions.

@Rexbeast2
Copy link
Contributor Author

@terriko I have updated the PR. can you review it.

Copy link
Contributor

@terriko terriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I do wonder if we should make a special config type, but since this is currently the only place it's used that seems like it would probably be overkill.

@terriko terriko merged commit 9b28243 into intel:main Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Getting rid of "Any" types
3 participants