Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve wireshark checker #2705

Merged
merged 1 commit into from
Feb 16, 2023
Merged

Conversation

ffontaine
Copy link
Contributor

Improve wireshark checker to avoid returning strings such as 3.4.1 for version 3.4.10

While at it, also add a debian test package

Improve wireshark checker to avoid returning strings such as 3.4.1 for
version 3.4.10

While at it, also add a debian test package

Signed-off-by: Fabrice Fontaine <fabrice.fontaine@orange.com>
@codecov-commenter
Copy link

Codecov Report

Merging #2705 (32fa611) into main (93c110c) will increase coverage by 0.93%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2705      +/-   ##
==========================================
+ Coverage   81.99%   82.92%   +0.93%     
==========================================
  Files         640      640              
  Lines       10001     9999       -2     
  Branches     1334     1334              
==========================================
+ Hits         8200     8292      +92     
+ Misses       1456     1369      -87     
+ Partials      345      338       -7     
Flag Coverage Δ
longtests 82.10% <100.00%> (+0.11%) ⬆️
win-longtests 79.52% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
test/test_data/wireshark.py 100.00% <ø> (ø)
cve_bin_tool/checkers/wireshark.py 100.00% <100.00%> (ø)
cve_bin_tool/checkers/__init__.py 95.34% <0.00%> (-0.21%) ⬇️
cve_bin_tool/nvd_api.py 18.32% <0.00%> (ø)
test/test_requirements.py 0.00% <0.00%> (ø)
cve_bin_tool/egg_updater.py 77.77% <0.00%> (ø)
cve_bin_tool/error_handler.py 91.42% <0.00%> (ø)
cve_bin_tool/helper_script.py 82.05% <0.00%> (ø)
test/test_scanner.py 80.00% <0.00%> (+0.60%) ⬆️
cve_bin_tool/async_utils.py 94.48% <0.00%> (+0.68%) ⬆️
... and 12 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@terriko terriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@terriko terriko merged commit f58ffcc into intel:main Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants