Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve nbd checker #2715

Merged
merged 1 commit into from
Feb 22, 2023
Merged

fix: improve nbd checker #2715

merged 1 commit into from
Feb 22, 2023

Conversation

ffontaine
Copy link
Contributor

Update nbd pattern to avoid false positive with upcoming linux_kernel checker

Update nbd pattern to avoid false positive with upcoming linux_kernel
checker

Signed-off-by: Fabrice Fontaine <fabrice.fontaine@orange.com>
@codecov-commenter
Copy link

Codecov Report

Merging #2715 (95b5724) into main (d750703) will increase coverage by 0.23%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2715      +/-   ##
==========================================
+ Coverage   82.02%   82.25%   +0.23%     
==========================================
  Files         640      640              
  Lines        9999     9999              
  Branches     1334     1334              
==========================================
+ Hits         8202     8225      +23     
+ Misses       1444     1437       -7     
+ Partials      353      337      -16     
Flag Coverage Δ
longtests 82.25% <ø> (+5.22%) ⬆️
win-longtests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cve_bin_tool/checkers/nbd.py 100.00% <ø> (ø)
cve_bin_tool/extractor.py 69.02% <0.00%> (-11.51%) ⬇️
cve_bin_tool/data_sources/redhat_source.py 62.91% <0.00%> (-7.29%) ⬇️
test/test_checkers.py 93.87% <0.00%> (-6.13%) ⬇️
cve_bin_tool/version_scanner.py 86.95% <0.00%> (-3.73%) ⬇️
cve_bin_tool/cve_scanner.py 77.90% <0.00%> (-3.49%) ⬇️
cve_bin_tool/output_engine/console.py 93.60% <0.00%> (-1.61%) ⬇️
cve_bin_tool/cli.py 66.56% <0.00%> (-1.28%) ⬇️
cve_bin_tool/output_engine/__init__.py 67.85% <0.00%> (-1.08%) ⬇️
cve_bin_tool/data_sources/nvd_source.py 56.04% <0.00%> (-0.81%) ⬇️
... and 15 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@terriko terriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting change. Thanks!

@terriko terriko merged commit c47d112 into intel:main Feb 22, 2023
@ffontaine ffontaine deleted the fix-nbd-checker branch February 22, 2023 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants