Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(checker): new vim checker> #2958

Merged
merged 1 commit into from
Apr 28, 2023
Merged

feat(checker): new vim checker> #2958

merged 1 commit into from
Apr 28, 2023

Conversation

stvml
Copy link
Contributor

@stvml stvml commented Apr 28, 2023

fixes #2920

fixes intel#2920

Co-authored-by: Steve Miller <steve.miller@intel.com>
@codecov-commenter
Copy link

codecov-commenter commented Apr 28, 2023

Codecov Report

Merging #2958 (1727efd) into main (e0bf4a6) will increase coverage by 0.92%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2958      +/-   ##
==========================================
+ Coverage   82.10%   83.03%   +0.92%     
==========================================
  Files         672      674       +2     
  Lines       10642    10651       +9     
  Branches     1436     1436              
==========================================
+ Hits         8738     8844     +106     
+ Misses       1521     1447      -74     
+ Partials      383      360      -23     
Flag Coverage Δ
longtests 82.10% <100.00%> (+6.02%) ⬆️
win-longtests 80.22% <100.00%> (+0.38%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cve_bin_tool/checkers/__init__.py 95.34% <ø> (ø)
test/test_checkers.py 100.00% <ø> (ø)
cve_bin_tool/checkers/vim.py 100.00% <100.00%> (ø)
test/test_data/vim.py 100.00% <100.00%> (ø)

... and 6 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@terriko terriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you! I'm not sure what's up with the cve-scan on this one -- it shouldn't be any different than main since it's not adding components -- but I filed an issue and will try to debug further some other time.

@terriko terriko merged commit edda316 into intel:main Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(checker): new checker request: vim
4 participants