Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve pango checker #2986

Merged
merged 1 commit into from
May 10, 2023
Merged

fix: improve pango checker #2986

merged 1 commit into from
May 10, 2023

Conversation

ffontaine
Copy link
Contributor

Improve pango checker to avoid false positives with upcoming emacs checker

Improve pango checker to avoid false positives with upcoming emacs
checker

Signed-off-by: Fabrice Fontaine <fabrice.fontaine@orange.com>
@ffontaine ffontaine force-pushed the fix-pango-checker branch from aa86212 to 43a9e60 Compare May 10, 2023 05:06
@codecov-commenter
Copy link

codecov-commenter commented May 10, 2023

Codecov Report

Merging #2986 (43a9e60) into main (9bdba0c) will increase coverage by 0.21%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2986      +/-   ##
==========================================
+ Coverage   82.67%   82.89%   +0.21%     
==========================================
  Files         674      674              
  Lines       10626    10626              
  Branches     1426     1426              
==========================================
+ Hits         8785     8808      +23     
+ Misses       1474     1457      -17     
+ Partials      367      361       -6     
Flag Coverage Δ
longtests 82.39% <100.00%> (+5.96%) ⬆️
win-longtests 80.16% <100.00%> (-0.21%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
test/test_data/pango.py 100.00% <ø> (ø)
cve_bin_tool/checkers/pango.py 100.00% <100.00%> (ø)

... and 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@terriko terriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks! Now I'll have to remember to edit the emacs checker on merge.

@terriko terriko merged commit 5c2ce74 into intel:main May 10, 2023
@ffontaine ffontaine deleted the fix-pango-checker branch May 10, 2023 20:55
ffontaine added a commit to ffontaine/cve-bin-tool that referenced this pull request May 12, 2023
Improve pango checker to avoid false positives with upcoming emacs
checker

Signed-off-by: Fabrice Fontaine <fabrice.fontaine@orange.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants