Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Automatically committing/suggesting linter fixes for PRs #3017

Merged
merged 6 commits into from
Jun 20, 2023

Conversation

metabiswadeep
Copy link
Contributor

Fixes #2925

@codecov-commenter
Copy link

codecov-commenter commented May 15, 2023

Codecov Report

Merging #3017 (0d7156d) into main (8ac34cf) will decrease coverage by 2.79%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #3017      +/-   ##
==========================================
- Coverage   82.93%   80.15%   -2.79%     
==========================================
  Files         684      712      +28     
  Lines       10704    10842     +138     
  Branches     1430     1258     -172     
==========================================
- Hits         8877     8690     -187     
- Misses       1460     1769     +309     
- Partials      367      383      +16     
Flag Coverage Δ
longtests ?
win-longtests 80.15% <ø> (-0.33%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 68 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@metabiswadeep metabiswadeep changed the title CI: Automatically committing/suggesting linter fixes for PRs ci: Automatically committing/suggesting linter fixes for PRs May 31, 2023
Copy link
Contributor

@terriko terriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good, just some minor changes requested to make sure this doesn't come up in the regular OSSF Scorecard scans next week.

@@ -44,3 +46,5 @@ jobs:
run: |
python -m pip install --upgrade gitlint
echo "$TITLE" | gitlint
- uses: stefanzweifel/git-auto-commit-action@v4
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update this line to use the git hash the way we did with the other workflows? (It was a recommendation as part of our OpenSSF scorecard efforts)

Example:
https://github.com/intel/cve-bin-tool/blob/main/.github/workflows/update-pre-commit.yml#L29

      - uses: actions/checkout@8e5e7e5ab8b370d6c329ec480221332ada57f0ab # v3.5.2

metabiswadeep and others added 2 commits June 7, 2023 16:55
Co-authored-by: Terri Oda <terri@toybox.ca>
@metabiswadeep metabiswadeep requested a review from terriko June 7, 2023 11:47
Copy link
Contributor

@terriko terriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@terriko terriko merged commit db59dd5 into intel:main Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI: Automatically committing/suggesting linter fixes for PRs
3 participants