-
Notifications
You must be signed in to change notification settings - Fork 506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Automatically committing/suggesting linter fixes for PRs #3017
Conversation
Codecov Report
@@ Coverage Diff @@
## main #3017 +/- ##
==========================================
- Coverage 82.93% 80.15% -2.79%
==========================================
Files 684 712 +28
Lines 10704 10842 +138
Branches 1430 1258 -172
==========================================
- Hits 8877 8690 -187
- Misses 1460 1769 +309
- Partials 367 383 +16
Flags with carried forward coverage won't be shown. Click here to find out more. see 68 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good, just some minor changes requested to make sure this doesn't come up in the regular OSSF Scorecard scans next week.
.github/workflows/linting.yml
Outdated
@@ -44,3 +46,5 @@ jobs: | |||
run: | | |||
python -m pip install --upgrade gitlint | |||
echo "$TITLE" | gitlint | |||
- uses: stefanzweifel/git-auto-commit-action@v4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you update this line to use the git hash the way we did with the other workflows? (It was a recommendation as part of our OpenSSF scorecard efforts)
- uses: actions/checkout@8e5e7e5ab8b370d6c329ec480221332ada57f0ab # v3.5.2
Co-authored-by: Terri Oda <terri@toybox.ca>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Fixes #2925