feat: updating schema #3106
feat: updating schema #3106
Conversation
Codecov Report
@@ Coverage Diff @@
## main #3106 +/- ##
==========================================
- Coverage 82.46% 81.58% -0.89%
==========================================
Files 714 714
Lines 10984 11000 +16
Branches 1477 1479 +2
==========================================
- Hits 9058 8974 -84
- Misses 1543 1625 +82
- Partials 383 401 +18
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 4 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
cve_bin_tool/cvedb.py
Outdated
|
|
||
| # Check schema on metrics | ||
| if not self.latest_schema("metrics", metrics_schema, cursor): | ||
| self.LOGGER.info("Upgrading cve_exploited data. This may take some time.") |
There was a problem hiding this comment.
The comment in line 403/412 should be cve_metrics data, However, we aren't actually downloading the data at this stage, just creating the table
There was a problem hiding this comment.
That is why I haven't included the download function. I have recently updated the table schema and made updates wherever it is referenced or utilized.
There was a problem hiding this comment.
I spent way too long staring at this wondering why you had a metrics table instead of an enum before I remembered that sqlite doesn't support enum. 🤦♀️ (I might be a little "hungover" from yesterday's migraine, sorry!)
I feel like we're going to have to refactor the actual schema update part before it turns into illegible gibberish with so many _ tossed in there, but I'm pretty sure that's my fault from the last revisions I did in there and not yours. In the interest of getting things merged before the weekend, I'm going to go ahead and get this merged now and we can refactor later if necessary. The failing tests don't appear to be related.
fixes: #3105