fix: improve version_compare to drop hashes #3566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently version_compare rasies an error when it gets a hash, since we can't really compare those without more knowledge of the product. This changes the code to silently drop hashes and similar distro markers from the end of versions, which should make our code more robust to real-life cases. We may also want to put in an error handler to log the versions we can't handle without halting the program, but this doesn't do that yet. Signed-off-by: Terri Oda <terri@toybox.ca>
Signed-off-by: Terri Oda <terri@toybox.ca>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3566 +/- ##
==========================================
+ Coverage 78.00% 78.29% +0.28%
==========================================
Files 761 763 +2
Lines 11572 11587 +15
Branches 1359 1360 +1
==========================================
+ Hits 9027 9072 +45
+ Misses 2123 2098 -25
+ Partials 422 417 -5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
antoniogi
approved these changes
Dec 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently version_compare rasies an error when it gets a hash, since we can't really compare those without more knowledge of the product. This changes the code to silently drop hashes and similar distro markers from the end of versions, which should make our code more robust to real-life cases. We may also want to put in an error handler to log the versions we can't handle without halting the program, but this doesn't do that yet.
Fixes #3556