Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(checker): add zstandard checker #3590

Merged
merged 2 commits into from
Dec 13, 2023
Merged

Conversation

ffontaine
Copy link
Contributor

No description provided.

Copy link
Contributor

@terriko terriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Windows is reporting some other things that contain zstandard:

 =========================== short test summary info ===========================
FAILED test/test_scanner.py::TestScanner::test_version_in_package[http://rpmfind.net/linux/opensuse/distribution/leap/15.5/repo/oss/aarch64/-grub2-2.06-150400.11.5.2.aarch64.rpm-grub2-2.06-other_products302] - AssertionError: zstandard found in grub2-2.06-150400.11.5.2.aarch64.rpm. If that's expected, make sure to add zstandard to the expected list of other_products.
assert 'zstandard' not in {'grub', 'grub2', 'zstandard'}
FAILED test/test_scanner.py::TestScanner::test_version_in_package[http://rpmfind.net/linux/opensuse/distribution/leap/15.5/repo/oss/ppc64le/-grub2-2.06-150400.11.5.2.ppc64le.rpm-grub2-2.06-other_products303] - AssertionError: zstandard found in grub2-2.06-150400.11.5.2.ppc64le.rpm. If that's expected, make sure to add zstandard to the expected list of other_products.
assert 'zstandard' not in {'grub', 'grub2', 'zstandard'}
FAILED test/test_scanner.py::TestScanner::test_version_in_package[http://ports.ubuntu.com/pool/main/m/mysql-8.0/-mysql-client-core-8.0_8.0.19-0ubuntu5_arm64.deb-mysql-8.0.19-other_products672] - AssertionError: zstandard found in mysql-client-core-8.0_8.0.19-0ubuntu5_arm64.deb. If that's expected, make sure to add zstandard to the expected list of other_products.
assert 'zstandard' not in {'mysql', 'zstandard'}
=========== 3 failed, 1860 passed, 32 skipped in 1240.71s (0:20:40) ===========

Signed-off-by: Fabrice Fontaine <fabrice.fontaine@orange.com>
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6cd07c4) 78.70% compared to head (3586d12) 78.55%.

❗ Current head 3586d12 differs from pull request most recent head bc3e172. Consider uploading reports for the commit bc3e172 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3590      +/-   ##
==========================================
- Coverage   78.70%   78.55%   -0.15%     
==========================================
  Files         767      769       +2     
  Lines       11611    11620       +9     
  Branches     1362     1362              
==========================================
- Hits         9138     9128      -10     
- Misses       2035     2074      +39     
+ Partials      438      418      -20     
Flag Coverage Δ
win-longtests 78.55% <100.00%> (-0.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ffontaine
Copy link
Contributor Author

PR updated

Copy link
Contributor

@terriko terriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks; that looks to have done the trick.

@terriko terriko merged commit a74d1ad into intel:main Dec 13, 2023
@ffontaine ffontaine deleted the add-zstd-checker branch December 13, 2023 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants