fix: improve lua checker #3598
Merged
fix: improve lua checker #3598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improve lua checker to avoid false positives with haproxy, nmap, vim and wireshark binaries which link dynamically with lua library (and save the associated version number) While at it, add an OpenWRT test package Signed-off-by: Fabrice Fontaine <fabrice.fontaine@orange.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3598 +/- ##
==========================================
+ Coverage 78.19% 78.48% +0.28%
==========================================
Files 773 773
Lines 11641 11641
Branches 1362 1362
==========================================
+ Hits 9103 9136 +33
+ Misses 2116 2087 -29
+ Partials 422 418 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
terriko
approved these changes
Dec 18, 2023
inosmeet
pushed a commit
to inosmeet/cve-bin-tool
that referenced
this pull request
Feb 16, 2024
Improve lua checker to avoid false positives with haproxy, nmap, vim and wireshark binaries which link dynamically with lua library (and save the associated version number) While at it, add an OpenWRT test package Signed-off-by: Fabrice Fontaine <fabrice.fontaine@orange.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve lua checker to avoid false positives with haproxy, nmap, vim and wireshark binaries which link dynamically with lua library (and save the associated version number)
While at it, add an OpenWRT test package