Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update binutils pattern #3615

Merged
merged 2 commits into from
Dec 19, 2023
Merged

Conversation

ffontaine
Copy link
Contributor

@ffontaine ffontaine commented Dec 17, 2023

Update binutils pattern to avoid a false positive in libtool.info-1 raised by libbfd-2.9.0.so

Update binutils pattern to avoid a false positive in libtool.info-1
raised by libbfd-2.9.0.so

This update will also allow to correctly detect binutils in gdb, linux
kernel and u-boot images

Signed-off-by: Fabrice Fontaine <fabrice.fontaine@orange.com>
@ffontaine ffontaine force-pushed the fix-binutils-checker branch from 4fdacc2 to 940e946 Compare December 17, 2023 15:26
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (10ddd3a) 78.66% compared to head (940e946) 78.31%.

❗ Current head 940e946 differs from pull request most recent head a2a8410. Consider uploading reports for the commit a2a8410 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3615      +/-   ##
==========================================
- Coverage   78.66%   78.31%   -0.35%     
==========================================
  Files         773      773              
  Lines       11641    11641              
  Branches     1362     1362              
==========================================
- Hits         9157     9117      -40     
- Misses       2048     2104      +56     
+ Partials      436      420      -16     
Flag Coverage Δ
win-longtests 78.31% <100.00%> (-0.33%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@terriko terriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting. Thanks for the fix!

@terriko
Copy link
Contributor

terriko commented Dec 19, 2023

Note to self: failing test was network related.

@terriko terriko merged commit 14b347f into intel:main Dec 19, 2023
@ffontaine ffontaine deleted the fix-binutils-checker branch December 19, 2023 20:57
inosmeet pushed a commit to inosmeet/cve-bin-tool that referenced this pull request Feb 16, 2024
Update binutils pattern to avoid a false positive in libtool.info-1
raised by libbfd-2.9.0.so

This update will also allow to correctly detect binutils in gdb, linux
kernel and u-boot images

Signed-off-by: Fabrice Fontaine <fabrice.fontaine@orange.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants