Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: improve interrogate/pre-commit config #3714

Merged
merged 2 commits into from
Jan 11, 2024
Merged

Conversation

terriko
Copy link
Contributor

@terriko terriko commented Jan 9, 2024

This is just the interrogate fix extracted from #3694 for easier review/merging.

@codecov-commenter
Copy link

codecov-commenter commented Jan 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6d4df4a) 79.58% compared to head (b59fe28) 79.17%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3714      +/-   ##
==========================================
- Coverage   79.58%   79.17%   -0.41%     
==========================================
  Files         803      803              
  Lines       11974    11974              
  Branches     1603     1603              
==========================================
- Hits         9529     9480      -49     
- Misses       1990     2055      +65     
+ Partials      455      439      -16     
Flag Coverage Δ
longtests 73.91% <ø> (-0.04%) ⬇️
win-longtests 77.18% <ø> (-0.42%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@antoniogi antoniogi self-requested a review January 10, 2024 16:42
Copy link

@antoniogi antoniogi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good!

@terriko terriko merged commit 9a942ce into intel:main Jan 11, 2024
22 checks passed
inosmeet pushed a commit to inosmeet/cve-bin-tool that referenced this pull request Feb 6, 2024
Switch our config to use pre-commit's file exclusions instead of interrogate's because it works better for local & github actions.

Signed-off-by: Terri Oda <terri.oda@intel.com>
inosmeet pushed a commit to inosmeet/cve-bin-tool that referenced this pull request Feb 16, 2024
Switch our config to use pre-commit's file exclusions instead of interrogate's because it works better for local & github actions.

Signed-off-by: Terri Oda <terri.oda@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants