ci: Add python 3.12 with fix from @milinddethe15 #3766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: milinddethe15 <milinddethe15@gmail.com> Signed-off-by: Terri Oda <terri.oda@intel.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3766 +/- ##
==========================================
+ Coverage 78.04% 80.40% +2.36%
==========================================
Files 803 805 +2
Lines 11810 11953 +143
Branches 1365 1595 +230
==========================================
+ Hits 9217 9611 +394
+ Misses 2158 1914 -244
+ Partials 435 428 -7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
inosmeet
pushed a commit
to inosmeet/cve-bin-tool
that referenced
this pull request
Feb 6, 2024
* fixes: intel#3495 Co-authored-by: milinddethe15 <milinddethe15@gmail.com> Signed-off-by: Terri Oda <terri.oda@intel.com>
inosmeet
pushed a commit
to inosmeet/cve-bin-tool
that referenced
this pull request
Feb 16, 2024
* fixes: intel#3495 Co-authored-by: milinddethe15 <milinddethe15@gmail.com> Signed-off-by: Terri Oda <terri.oda@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@milinddethe15 did some investigation and found that things should work if the -dev package was installed. Looks like we can't explicitly install python3.12-dev but we already install python3-dev with the pdf testing components so this may work.
(I haven't checked if the tests will pass yet, though)