Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: tempfile cleanup for python-requirements parser #3966

Merged
merged 8 commits into from
Apr 3, 2024

Conversation

joydeep049
Copy link
Contributor

@joydeep049 joydeep049 commented Mar 22, 2024

Tempfile cleanup for python-requirements.txt
@terriko @anthonyharrison

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.73%. Comparing base (d6cbe40) to head (95f42ff).
Report is 114 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3966      +/-   ##
==========================================
+ Coverage   75.41%   75.73%   +0.32%     
==========================================
  Files         808      820      +12     
  Lines       11983    12405     +422     
  Branches     1598     1680      +82     
==========================================
+ Hits         9037     9395     +358     
- Misses       2593     2655      +62     
- Partials      353      355       +2     
Flag Coverage Δ
longtests 75.73% <ø> (+0.32%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joydeep049 joydeep049 changed the title feat: tempfile cleanup for python-requirements.txt feat: tempfile cleanup for python-requirements parser Mar 26, 2024
Copy link
Contributor

@terriko terriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I didn't bother to update the year in this one because it wasn't easy to for me to do from the review interface like it was with the other, but we can update it some other time if we want.

@terriko terriko merged commit f4d96e9 into intel:main Apr 3, 2024
23 checks passed
@joydeep049
Copy link
Contributor Author

Looks good. I didn't bother to update the year in this one because it wasn't easy to for me to do from the review interface like it was with the other, but we can update it some other time if we want.

Should I open a PR for it? Could be a nice good first issue for new contributors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants