-
Notifications
You must be signed in to change notification settings - Fork 506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added PURL generation to DartParser #4004
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4004 +/- ##
==========================================
- Coverage 75.41% 75.39% -0.02%
==========================================
Files 808 820 +12
Lines 11983 12600 +617
Branches 1598 1711 +113
==========================================
+ Hits 9037 9500 +463
- Misses 2593 2744 +151
- Partials 353 356 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This looks good. I don't think any changes are needed. @mastersans |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Marking this as approved now, but I don't know if I'll merge it before or after release. Since this doesn't affect scan results it really doesn't matter which way we go; I'm just reviewing it now while I'm waiting for some other scans to finish.
Decided to add the links @mastersans had above into the docstring so they're available easily for future reference. Tests are going to re-run now. |
Related: #3771
References:
pubspec
purl-spec for pub