Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added PURL generation to DartParser #4004

Merged
merged 7 commits into from
Apr 16, 2024
Merged

Conversation

mastersans
Copy link
Member

@mastersans mastersans commented Apr 7, 2024

Related: #3771

References:
pubspec
purl-spec for pub

@codecov-commenter
Copy link

codecov-commenter commented Apr 7, 2024

Codecov Report

Attention: Patch coverage is 30.00000% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 75.39%. Comparing base (d6cbe40) to head (dc2c413).
Report is 165 commits behind head on main.

Files Patch % Lines
cve_bin_tool/parsers/dart.py 30.00% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4004      +/-   ##
==========================================
- Coverage   75.41%   75.39%   -0.02%     
==========================================
  Files         808      820      +12     
  Lines       11983    12600     +617     
  Branches     1598     1711     +113     
==========================================
+ Hits         9037     9500     +463     
- Misses       2593     2744     +151     
- Partials      353      356       +3     
Flag Coverage Δ
longtests 75.39% <30.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joydeep049
Copy link
Contributor

This looks good. I don't think any changes are needed. @mastersans
cc @terriko

Copy link
Contributor

@terriko terriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Marking this as approved now, but I don't know if I'll merge it before or after release. Since this doesn't affect scan results it really doesn't matter which way we go; I'm just reviewing it now while I'm waiting for some other scans to finish.

@terriko terriko added this to the 3.3.1 milestone Apr 10, 2024
@terriko
Copy link
Contributor

terriko commented Apr 16, 2024

Decided to add the links @mastersans had above into the docstring so they're available easily for future reference. Tests are going to re-run now.

@terriko terriko merged commit 0f17d3a into intel:main Apr 16, 2024
22 checks passed
@mastersans mastersans deleted the purl-dart branch April 18, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants