-
Notifications
You must be signed in to change notification settings - Fork 506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: use unique tempdir prefixes in fuzzing temp dirs (fixes: #3960) #4022
chore: use unique tempdir prefixes in fuzzing temp dirs (fixes: #3960) #4022
Conversation
7bb57d5
to
00821cf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking pretty good. Can you remove the changes to the files in fuzz/generated/* ? We don't really want to change those.
@terriko Thanks, the changes in fuzz/generated/* are due to the linter. If you still want them to the original state, I can fix it! |
Yes, original state please! The linter as we have it configured in pre-commit should ignore anything in that directory; if that's not working then we should fix that separately. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4022 +/- ##
==========================================
+ Coverage 75.41% 75.44% +0.03%
==========================================
Files 808 822 +14
Lines 11983 12699 +716
Branches 1598 1734 +136
==========================================
+ Hits 9037 9581 +544
- Misses 2593 2752 +159
- Partials 353 366 +13
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: ranjanmangla1 <ranjanmangla1@gmail.com>
d9bcd01
to
2c261d7
Compare
@terriko Please review, I have fixed it! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like there's still a few generated files in here that need to be removed:
- fuzz/generated/cargo_lock_pb2.py
- fuzz/generated/composer_lock_pb2.py
- fuzz/generated/pom_xml_pb2.py
The diff checker is explaining why: there's a difference in the final carriage return/line feed/new line on them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You may need to use git checkout origin/main filename
and then git add those again to fix them to be exactly what main has.
Hello @ranjanmangla1 , as @terriko said, you should remove all the changes to the generated pb2 files as we would not wanna touch them at this point. |
Signed-off-by: ranjanmangla1 <ranjanmangla1@gmail.com>
@terriko @joydeep049 I have fixed it. Thank you for your patience @terriko and sorry for bothering you for a silly mistake by me in this pr. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good now! Thanks for iterating on this @ranjanmangla1 ; I know generated files and non-obvious whitespace changes at the end of file can both be dreadful traps in git, so hurray for finally managing to evade them all!
fixes #3960
I have used the following nomenclature for temp dir: cve-bin-tool-FUZZ_<UTILITY / USED FOR>