Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add additional ppp CPE ID #4092

Merged
merged 1 commit into from
Apr 29, 2024
Merged

Conversation

ffontaine
Copy link
Contributor

@codecov-commenter
Copy link

codecov-commenter commented Apr 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.52%. Comparing base (d6cbe40) to head (d23e4db).
Report is 194 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4092      +/-   ##
==========================================
+ Coverage   75.41%   81.52%   +6.11%     
==========================================
  Files         808      820      +12     
  Lines       11983    12533     +550     
  Branches     1598     1941     +343     
==========================================
+ Hits         9037    10218    +1181     
+ Misses       2593     1892     -701     
- Partials      353      423      +70     
Flag Coverage Δ
longtests 81.04% <100.00%> (+5.62%) ⬆️
win-longtests 79.37% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ffontaine ffontaine changed the title fix: update VENDOR_PRODUCT fix: add additional ppp CPE ID Apr 28, 2024
@ffontaine ffontaine force-pushed the update-ppp-checker branch from dca4e12 to d23e4db Compare April 28, 2024 13:45
samba:ppp is also a valid CPE ID:
https://nvd.nist.gov/products/cpe/search/results?keyword=cpe:2.3:a:samba:ppp

Signed-off-by: Fabrice Fontaine <fabrice.fontaine@orange.com>
Copy link
Contributor

@terriko terriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@terriko terriko merged commit 8de8ca2 into intel:main Apr 29, 2024
22 checks passed
@ffontaine ffontaine deleted the update-ppp-checker branch April 29, 2024 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants