Skip to content
This repository has been archived by the owner on Aug 25, 2024. It is now read-only.

cleanup: Rename master branch to main #984

Open
johnandersen777 opened this issue Feb 10, 2021 · 7 comments
Open

cleanup: Rename master branch to main #984

johnandersen777 opened this issue Feb 10, 2021 · 7 comments
Labels
enhancement New feature or request housekeeping Restructuring, refactoring, removal of old functionality, etc. tM Esitmated Time To Complete: Medium

Comments

@johnandersen777
Copy link

johnandersen777 commented Feb 10, 2021

There are a lot of references to master through out our codebase. git grep will be your friend here.

Please rename all instances of master that refer to a git branch to main. Please provide a list in your PR of all the remaining instances of master as found by git grep -n, with some at least small not detailing why it doesn't need to change, so that reviewers can review your PR quickly.

@johnandersen777 johnandersen777 added enhancement New feature or request good first issue Good for newcomers housekeeping Restructuring, refactoring, removal of old functionality, etc. labels Feb 10, 2021
@version0chiro
Copy link

I would like to work on this issue, if only the renaming of the 'master' references to 'main' is required or I need to do some checkout?

@johnandersen777
Copy link
Author

@version0chiro Try to start re-naming things, push a PR, and we'll see what happens

@johnandersen777 johnandersen777 added the tS Esitmated Time To Complete: Short label Feb 12, 2021
@rajpratyush
Copy link

@pdxjohnny I have tried renaming in my local branch but there was no pr generated . Can you assist me

@rajpratyush
Copy link

@pdxjohnny doesn't it requires admin access??

@rupesh-dharme
Copy link

Can you assign this issue to me
I would like to try

@programmer290399
Copy link
Contributor

Hi @RupeshRavindraDharme !!
I guess @Saanidhyavats has a PR on this already i.e. #1031
But probably that'd need some updates since original master has progressed quite a lot since then.
Also as I can see there is something that is blocking the merge of this PR as it is labelled as waiting to merge.

Please discuss this once with @Saanidhyavats & @pdxjohnny before proceeding with that PR.

@johnandersen777 johnandersen777 added tM Esitmated Time To Complete: Medium and removed good first issue Good for newcomers tS Esitmated Time To Complete: Short labels Oct 9, 2021
@johnandersen777
Copy link
Author

This is shaping up to be fairly complex. We’re going to split out things into the second party plugin #1061 repo structure. When we do that we should probably do this at the same time. I’ve removed the good first issue tag

johnandersen777 pushed a commit that referenced this issue Mar 12, 2022
Related: #1324
Related: #984
Signed-off-by: John Andersen <johnandersenpdx@gmail.com>
johnandersen777 pushed a commit that referenced this issue Mar 12, 2022
Related: #1324
Related: #984
Signed-off-by: John Andersen <johnandersenpdx@gmail.com>
johnandersen777 pushed a commit that referenced this issue Mar 12, 2022
Rename and then checkout anything that doesn't apply

.. code-block:: console

    $ sed -i 's/master/main/g' $(git ls-files)
    $ sed -i 's/MASTER/MAIN/g' $(git ls-files)
    $ git checkout -p --

Related: #984
Signed-off-by: John Andersen <johnandersenpdx@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request housekeeping Restructuring, refactoring, removal of old functionality, etc. tM Esitmated Time To Complete: Medium
Projects
None yet
Development

No branches or pull requests

5 participants