Remove runtime assert for kernel finish_counter. #37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the kerne's finish_counter assert > 0 is called whenever there is a kernel interrupt sent. However the kernel interrupt could be sent whenever: 1. printf buffer is full 2. The kernel change state: init -> running -> finish/stall 3. clGetProfileInfoIntelFPGA is called From the first reason, it already doesn't make sense to assert finish counter greater than 0, as is very possible for a printf buffer to be full before the kernel finishes.
pcolberg
force-pushed
the
remove_finish_count_assert
branch
from
22901bd to
8a023ba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the kernel's finish_counter assert > 0 is called whenever there is a kernel interrupt sent. However the kernel interrupt could be sent whenever:
From the first reason, it already doesn't make sense to assert finish counter greater than 0, as is very possible for a printf buffer to be full before the kernel finishes.