Filter PIDs to profile #761

mpozniak95 · 2023-04-05T13:48:48Z

Description

This PR:

Add flag --pid that enables providing chosen pids to profile
Checks if at least one of processes provided is alive
pids are passed to profilers via ProfilerState
Adds test for checking if only provided pid is profiled with async-profiler

Related Issue

…ofiling only pids provided

mpozniak95 · 2023-04-05T13:50:49Z

I'll open two more issues and I'll link them to the code. It seems that flags --pid/-p doesn't work as intendent in pyperf and phpspy. Pyperf seems to ignore this parameter and phpspy is getting stuck with this flag

Jongy

Looks good :) I gave some comments. Did not try it out locally yet, will do that after the next CR round.

gprofiler/main.py

tests/test_sanity.py

gprofiler/profiler_state.py

gprofiler/profilers/perf.py

…ove usage of extend

… and ProfilerState classes constructors kwargs-only

mpozniak95 · 2023-04-11T07:32:36Z

Two tests failed in CI/CD but I think that it isn't connected with these changes

gprofiler/profiler_state.py

gprofiler/main.py

gprofiler/gprofiler_types.py

gprofiler/main.py

Jongy

Done reviewing

…or ProfilerState and GProfiler classes

Jongy

Awesome. Gave a few minor comments. I'll play with it a bit locally now and write my impression, currently no other comment besides those few and then it's good to merge.

gprofiler/main.py

gprofiler/profilers/profiler_base.py

gprofiler/main.py

gprofiler/profilers/perf.py

Jongy

Done reviewing and trying it out. 2 UX comments and we can merge

gprofiler/profilers/profiler_base.py

gprofiler/main.py

Jongy · 2023-04-12T15:57:30Z

gprofiler/main.py

@@ -943,7 +980,8 @@ def main() -> None:
        logger.info(
            "Running gProfiler", version=__version__, commandline=" ".join(sys.argv[1:]), arguments=args.__dict__
        )
-
+        if processes_to_profile is not None:
+            logger.info("Target PIDs given by --pids: ", pids=[process.pid for process in processes_to_profile])


This looks like:

[2023-04-12 15:56:36,138] INFO: gprofiler: Target PIDs given by --pids: (pids=[1])

No need for the : and the space, since logging adds it anyway when formatting the extras.

gprofiler/main.py

mpozniak95 added 5 commits March 30, 2023 15:24

Add --pids flag that enables profiling only provided pids

f37e6f4

Enable filtering pids in pyperf, perf and phpspy

bb1673a

Fix file formatting

d798298

Remove debug lines, for phpspy and pyperf filter output instead of pr…

ecc81ca

…ofiling only pids provided

Check if any of provided PID is alive

c9c3562

This was referenced Apr 6, 2023

Adding flag --pid/-p to phpspy results in GProfiler getting stuck #763

Open

Adding flag --pid/-p to pyperf doesn't result as intended #764

Open

Add comments with links to issues for pyperf and phpspy

ae2ef5f

mpozniak95 requested a review from Jongy April 6, 2023 08:11

Jongy suggested changes Apr 6, 2023

View reviewed changes

mpozniak95 added 8 commits April 7, 2023 08:41

Change extra_args variable to pid_args variable in perf profiler, rem…

74a64cc

…ove usage of extend

Use kwargs in ProfilerState class

5b2f3d2

Add two more asserts in test_profiling_provided_pids

8473ad9

Move checking for alive PID's to verify_preconditions, make GProfiler…

7e63f40

… and ProfilerState classes constructors kwargs-only

Filter out only alive pids from pids_to_profile list

08a19ae

Fix tests

8178673

Fix tests

3b2bec9

Fix checking if pids flag provided with profile-spawned

b42e05e

mpozniak95 requested a review from Jongy April 11, 2023 07:32

Jongy added the enhancement New feature or request label Apr 11, 2023

Jongy reviewed Apr 11, 2023

View reviewed changes

gprofiler/profiler_state.py Outdated Show resolved Hide resolved

Jongy reviewed Apr 11, 2023

View reviewed changes

gprofiler/main.py Outdated Show resolved Hide resolved

Jongy reviewed Apr 11, 2023

View reviewed changes

gprofiler/gprofiler_types.py Outdated Show resolved Hide resolved

Jongy reviewed Apr 11, 2023

View reviewed changes

gprofiler/main.py Outdated Show resolved Hide resolved

Jongy reviewed Apr 11, 2023

View reviewed changes

gprofiler/main.py Outdated Show resolved Hide resolved

Jongy reviewed Apr 11, 2023

View reviewed changes

gprofiler/main.py Outdated Show resolved Hide resolved

Jongy suggested changes Apr 11, 2023

View reviewed changes

Store list of processes to profile instead of pids, fix kwargs-only f…

406c378

…or ProfilerState and GProfiler classes

mpozniak95 requested a review from Jongy April 11, 2023 12:53

Jongy suggested changes Apr 11, 2023

View reviewed changes

gprofiler/main.py Outdated Show resolved Hide resolved

gprofiler/main.py Outdated Show resolved Hide resolved

gprofiler/main.py Outdated Show resolved Hide resolved

gprofiler/main.py Outdated Show resolved Hide resolved

Jongy reviewed Apr 11, 2023

View reviewed changes

gprofiler/profilers/profiler_base.py Show resolved Hide resolved

Jongy reviewed Apr 11, 2023

View reviewed changes

gprofiler/main.py Show resolved Hide resolved

mpozniak95 added 2 commits April 12, 2023 09:03

Log PID's given by --pids

09fea34

Move logging pids given after initializing logger

c57bef1

Jongy reviewed Apr 12, 2023

View reviewed changes

gprofiler/profilers/perf.py Outdated Show resolved Hide resolved

mpozniak95 added 2 commits April 12, 2023 14:09

Don't use flag -a with flag -p when using perf

89dd8d8

Reformat perf profiler file

7b921d2

Jongy suggested changes Apr 12, 2023

View reviewed changes

gprofiler/profilers/profiler_base.py Outdated Show resolved Hide resolved

gprofiler/main.py Outdated Show resolved Hide resolved

Move logging given pids after starting gprofiler log

5b0a765

Jongy reviewed Apr 12, 2023

View reviewed changes

gprofiler/main.py Outdated Show resolved Hide resolved

Update gprofiler/main.py

177459c

Jongy approved these changes Apr 12, 2023

View reviewed changes

Jongy merged commit df84102 into intel:master Apr 12, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Filter PIDs to profile #761

Filter PIDs to profile #761

mpozniak95 commented Apr 5, 2023

mpozniak95 commented Apr 5, 2023 •

edited

Loading

Jongy left a comment

mpozniak95 commented Apr 11, 2023

Jongy left a comment

Jongy left a comment

Jongy left a comment

Jongy Apr 12, 2023

Filter PIDs to profile #761

Filter PIDs to profile #761

Conversation

mpozniak95 commented Apr 5, 2023

Description

Related Issue

mpozniak95 commented Apr 5, 2023 • edited Loading

Jongy left a comment

Choose a reason for hiding this comment

mpozniak95 commented Apr 11, 2023

Jongy left a comment

Choose a reason for hiding this comment

Jongy left a comment

Choose a reason for hiding this comment

Jongy left a comment

Choose a reason for hiding this comment

Jongy Apr 12, 2023

Choose a reason for hiding this comment

mpozniak95 commented Apr 5, 2023 •

edited

Loading