This repository has been archived by the owner on Jan 28, 2023. It is now read-only.
Fix macOS build failure on SDK 10.12 and host crash. #232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wcwang
approved these changes
Aug 14, 2019
Macro panic() is expand to postfix with panic line number, when passing a va_list to panic(), the macro can't expand correctly. Since panic() is now wrapped with hax_panic(), the line number always points inside hax_panic() which isn't necessary. Directly use (panic) instead of the macro. Before hax logger refine, hax_log_level() incorrectly use printf() for va_list. However it should use vprintf(). The new hax_log() inherits from hax_log_level() but doens't fix printf()->vprintf(). Signed-off-by: Colin Xu <colin.xu@intel.com>
coxuintel
changed the title
HaxmCI
added
CI:Build Pass
wcwang
approved these changes
Aug 16, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Macro panic() is expand to postfix with panic line number, when passing
a va_list to panic(), the macro can't expand correctly.
Since panic() is now wrapped with hax_panic(), the line number always
points inside hax_panic() which isn't necessary.
Use panic_plain instead.
Before hax logger refine, hax_log_level() incorrectly use printf() for
va_list. However it should use vprintf(). The new hax_log() inherits
from hax_log_level() but doens't fix printf()->vprintf().
Signed-off-by: Colin Xu colin.xu@intel.com