e2e: make tests divided into smaller parts (DLB, DSA, IAA, QAT) #1263
Conversation
hj-johannes-lee
requested review from
mythi,
bart0sh and
ozhuraki
as code owners
Codecov Report
@@ Coverage Diff @@
## main #1263 +/- ##
=======================================
Coverage 51.17% 51.17%
=======================================
Files 44 44
Lines 4879 4879
=======================================
Hits 2497 2497
Misses 2239 2239
Partials 143 143
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
these can go to a separate PR |
|
@mythi Sure, i will divide them.! |
hj-johannes-lee
changed the title
|
Updates: To do (maybe in another PR): We need to deal with this matter. |
|
Could you review? :) |
|
Is there a possibility this breaks if Ginkgo randomizes things differently? Now the test cases have a dependency and it might be that the demo app gets deployed before the plugin? |
|
@mythi yes, I thought about that matter,, and there is 'ginkgo. Order' that makes everything run in order. Following ones are skipped in case previous It() fails. |
randomisation is on purpose to ensure the tests are correctly written so I don't think we want to disable it |
|
@mythi Umm, did I understand what you meant correctly? What 'randomization' do we have for now? We have only one It()! |
I was reading this before asking my question https://onsi.github.io/ginkgo/#spec-randomization |
|
I then suggest this way: Describe ("device")
In this way, we can randomize specs and does not cause any problem no matter how many It()s exists. |
The proposal looks much better and closer to what I originally had in mind with #1143 |
|
@mythi Thanks! :) I guess all ci passed.! Please review the code! :) |
It's fine. For this PR, I'd suggest we change things to one commit per device. |
|
@mythi Done.! What else would this pr you think need? :) |
|
@ozhuraki Could you review? |
|
After this get merged, let me also make a pr for the improvement of documentations for e2e tests.! |
Structure is as follows:
Describe("DLB plugin")
BeforeEach("deploys plugin")
Context("When device resources are available")
BeforeEach("checks if resources are available")
It("runs a pod requesting resources")
Signed-off-by: Hyeongju Johannes Lee <hyeongju.lee@intel.com>
Structure is as follows:
Describe("DSA plugin")
Describe("without using operator")
BeforeEach("deploys plugin")
Context("When device resources are available")
BeforeEach("checks if resources are available")
It("runs a pod requesting resources")
Describe("with using operator")
It("deploys with operator")
Signed-off-by: Hyeongju Johannes Lee <hyeongju.lee@intel.com>
Structure is as follows:
Describe("IAA plugin")
Describe("without using operator")
BeforeEach("deploys plugin")
Context("When device resources are available")
BeforeEach("checks if resources are available")
It("runs a pod requesting resources")
Describe("with using operator")
It("deploys with operator")
Signed-off-by: Hyeongju Johannes Lee <hyeongju.lee@intel.com>
Structure is as follows:
Describe("QAT plugin")
BeforeEach("deploys plugin")
Context("When device resources are available")
BeforeEach("checks if resources are available")
It("runs a pod requesting resources")
It("runs another pod requesting resources if there is")
Signed-off-by: Hyeongju Johannes Lee <hyeongju.lee@intel.com>
Restructure e2e tests from a single It() as follows:
Signed-off-by: Hyeongju Johannes Lee hyeongju.lee@intel.com