operator: fix setting QAT provisioning config volumeMount

[mythi]

setInitContainer() adds "init-sriov-numvfs" to initContainers but uses initcontainerName constant to search where to add the QAT configMap volumeMount. Fix by moving all code to use the const.

It was also noticed in the controller logs that setting Pod Volumes is not idempotent but broken DaemonSet gets created:

""intel-device-plugins-manager: Reconciler error "err="DaemonSet.apps "intel-qat-plugin" is invalid: spec.template.spec.volumes[6].name: Duplicate value: "qat-config"" controller="qatdeviceplugin" controllerGroup="deviceplugin.intel.com"

Finally, change 'qat-config' to 'intel-qat-config-volume' to better describe that it's a volume.

[mythi]

@hj-johannes-lee I need your help testing this. I did an initial pass but pls check all the possible user flows on your side too

[codecov-commenter]

Codecov Report

Merging #1431 (344f94b) into main (a5c6243) will decrease coverage by 0.22%.
The diff coverage is 0.00%.

❗ Current head 344f94b differs from pull request most recent head 52d3d4a. Consider uploading reports for the commit 52d3d4a to get more accurate results

@@            Coverage Diff             @@
##             main    #1431      +/-   ##
==========================================
- Coverage   51.07%   50.86%   -0.22%     
==========================================
  Files          44       44              
  Lines        5010     5013       +3     
==========================================
- Hits         2559     2550       -9     
- Misses       2305     2317      +12     
  Partials      146      146              

Impacted Files	Coverage Δ
pkg/controllers/qat/controller.go	9.72% <0.00%> (-5.11%)	⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[hj-johannes-lee]

Sure, let me do!

[hj-johannes-lee]

built an operator from your branch and made it pulled Always.
Testing with the image, I tested

1. creating without putting any provisioningConfig value && updating yaml to have it and set as dc.
2. creating with provisioningConfig (dc) && updating configMap and yaml (cy).
3. cy first and updating to dc
   Is there any possible flow related to this pr?

[mythi]

4. Pre-provision manually and deploy without initImage. Update it (kubectl edit) to add it and then remove it again

[mythi]

4. Pre-provision manually and deploy without initImage. Update it (kubectl edit) to add it and then remove it again

and that no Reconcile errors show up in controller's logs

[hj-johannes-lee]

(I am now trying to debug found errors!)

[hj-johannes-lee]

existing errors are not related to this pr.
LGTM! :)