Skip to content

Implement DLB plugin #733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 11, 2021
Merged

Implement DLB plugin #733

merged 4 commits into from
Nov 11, 2021

Conversation

bart0sh
Copy link
Member

@bart0sh bart0sh commented Oct 21, 2021 •
edited
Loading

DLB plugin enables Dynamic Load Balancer accelerator.

@bart0sh bart0sh changed the title Implement DLB plugin WIP: Implement DLB plugin Oct 21, 2021
@bart0sh bart0sh force-pushed the PR115-implement-DLB-plugin branch from a37c5c4 to 63c2e51 Compare October 21, 2021 09:09
@bart0sh bart0sh force-pushed the PR115-implement-DLB-plugin branch 2 times, most recently from 2e63016 to eb35106 Compare November 1, 2021 16:22
@msivosuo msivosuo mentioned this pull request Nov 2, 2021
Closed
3 tasks
@bart0sh
Copy link
Member Author

bart0sh commented Nov 2, 2021

@hj-johannes-lee image build is still failing, PTAL

@bart0sh bart0sh force-pushed the PR115-implement-DLB-plugin branch from 7a613d4 to 5d6b405 Compare November 2, 2021 11:14
@codecov-commenter
Copy link

codecov-commenter commented Nov 2, 2021 •
edited
Loading

Codecov Report

Merging #733 (9bcd603) into main (ae985c4) will increase coverage by 0.44%.
The diff coverage is 97.05%.

❗ Current head 9bcd603 differs from pull request most recent head 2c3b13d. Consider uploading reports for the commit 2c3b13d to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main     #733      +/-   ##
==========================================
+ Coverage   60.06%   60.51%   +0.44%     
==========================================
  Files          32       33       +1     
  Lines        2782     2816      +34     
==========================================
+ Hits         1671     1704      +33     
- Misses       1028     1029       +1     
  Partials       83       83
Impacted Files Coverage Δ
cmd/dlb_plugin/kerneldrv/kerneldrv.go 97.05% <97.05%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae985c4...2c3b13d. Read the comment docs.

@hj-johannes-lee
Copy link
Contributor

I do not understand actually why docker build get succeeded and buildah doesn't in the main repo.. , but I found the way to solve the error..

It is because of tar ownership matter as you can see,, and I can remove the error by putting the --no-same-owner for tar command.

But I do not know whether it is a proper solution or not.!

@hj-johannes-lee hj-johannes-lee marked this pull request as ready for review November 2, 2021 11:23
@bart0sh
Copy link
Member Author

bart0sh commented Nov 2, 2021

@hj-johannes-lee the solution looks ok to me. Please, submit a PR.

@bart0sh bart0sh force-pushed the PR115-implement-DLB-plugin branch from 6129a2f to 2c3b13d Compare November 2, 2021 15:10
@bart0sh bart0sh force-pushed the PR115-implement-DLB-plugin branch 5 times, most recently from d1d4931 to 2b732f6 Compare November 10, 2021 14:13
@bart0sh bart0sh changed the title WIP: Implement DLB plugin Implement DLB plugin Nov 11, 2021
@hj-johannes-lee @bart0sh
dlb: Add new device plugin
8362028 
Signed-off-by: Hyeongju Johannes Lee <hyeongju.lee@intel.com>
@bart0sh bart0sh force-pushed the PR115-implement-DLB-plugin branch 2 times, most recently from 7e772d8 to 3209f3f Compare November 11, 2021 10:02
@bart0sh
Copy link
Member Author

bart0sh commented Nov 11, 2021

@rojkov @kad @uniemimu This PR was already reviewed by @bart0sh and @mythi. Now it's your turn. PTAL.

bart0sh and others added 2 commits November 11, 2021 12:07
@bart0sh
dlb: add dpdk demo
7e292bb 
Signed-off-by: Ed Bartosh <eduard.bartosh@intel.com>
Signed-off-by: Hyeongju Johannes Lee <hyeongju.lee@intel.com>
@hj-johannes-lee @bart0sh
dlb: add libdlb demo
ef1c26c 
Signed-off-by: Hyeongju Johannes Lee <hyeongju.lee@intel.com>
@bart0sh bart0sh force-pushed the PR115-implement-DLB-plugin branch from 3209f3f to 3118611 Compare November 11, 2021 10:08
@bart0sh bart0sh requested a review from uniemimu November 11, 2021 10:19
@bart0sh bart0sh requested a review from ozhuraki November 11, 2021 10:19
rojkov
rojkov reviewed Nov 11, 2021
View reviewed changes
@bart0sh
dlb: add documentation
b03227f 
Document DLB plugin

Signed-off-by: Hyeongju Johannes Lee <hyeongju.lee@intel.com>
Signed-off-by: Ed Bartosh <eduard.bartosh@intel.com>
@bart0sh bart0sh force-pushed the PR115-implement-DLB-plugin branch from 3118611 to b03227f Compare November 11, 2021 10:25
rojkov
rojkov approved these changes Nov 11, 2021
View reviewed changes
Copy link
Contributor

@rojkov rojkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

uniemimu
uniemimu reviewed Nov 11, 2021
View reviewed changes
Copy link
Contributor

@uniemimu uniemimu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mythi mythi merged commit 480514f into intel:main Nov 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uniemimu uniemimu uniemimu left review comments

@rojkov rojkov rojkov approved these changes

@mythi mythi mythi approved these changes

@hj-johannes-lee hj-johannes-lee Awaiting requested review from hj-johannes-lee hj-johannes-lee is a code owner

@kad kad Awaiting requested review from kad kad is a code owner

@ozhuraki ozhuraki Awaiting requested review from ozhuraki

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@bart0sh @codecov-commenter @hj-johannes-lee @uniemimu @rojkov @mythi