ci: Add envtest #755
ci: Add envtest #755
Conversation
hj-johannes-lee
requested review from
bart0sh,
kad,
mythi and
rojkov
as code owners
| ${{ runner.os }}-go- | ||
| - name: Install controller-runtime and get envtest binaries | ||
| run: | | ||
| go install sigs.k8s.io/controller-runtime/tools/setup-envtest@latest |
There was a problem hiding this comment.
Doesn't this line install envtest binaries? If so, why do we need to download and unpack them?
There was a problem hiding this comment.
Does it..?
I cannot see where the binaries are..
https://github.com/hj-johannes-lee/intel-device-plugins-for-kubernetes/runs/4256699647?check_suite_focus=true#step:5:3
And also,, there is an issue of using 1.22 kubernetes version.. so I thought it would be better to get the binaries just separately.
kubernetes-sigs/controller-runtime#1571 (comment)
There was a problem hiding this comment.
Why did you close this PR?
as for setup-envtest tool, it can manage multiple versions of binaries, e.g.
$ setup-envtest list
(installed) v1.22.1 linux/amd64
(available) v1.22.1 linux/amd64
(available) v1.22.0 linux/amd64
(available) v1.21.4 linux/amd64
(available) v1.21.2 linux/amd64
(available) v1.20.2 linux/amd64
(available) v1.19.2 linux/amd64
(available) v1.19.0 linux/amd64
(available) v1.17.9 linux/amd64
(available) v1.16.4 linux/amd64
(available) v1.15.5 linux/amd64
(available) v1.14.1 linux/amd64
(available) v1.13.1 linux/amd64
(available) v1.12.3 linux/amd64
(available) v1.11.0 linux/amd64
(available) v1.10.1 linux/amd64
Please, read its documentation for further details: https://pkg.go.dev/sigs.k8s.io/controller-runtime/tools/setup-envtest#section-readme
There was a problem hiding this comment.
Thank you for your help.! I think i should have just read the setup-envtest readme in more detail.!
I.. closed for a while since I just wanted to forced-push to my branch to see whether it works in github actions or not and that will create so many actions here too (though I think now that I could have just made another temporary branch..!)
I thought I can open again, but I guess,, I need to just make another pr after forced-push to the commit.
There was a problem hiding this comment.
I thought I can open again, but I guess,, I need to just make another pr after forced-push to the commit.
Looks like you pushed and then closed. To just re-open BEFORE pushing something again should keep this PR working.
There was a problem hiding this comment.
I see. I didn't know about that. Let me try not to make an unnecessary pr from now on!
Signed-off-by: Hyeongju Johannes Lee <hyeongju.lee@intel.com>
Closes: #566
Signed-off-by: Hyeongju Johannes Lee hyeongju.lee@intel.com