[Triton] change target[1] to sycl_device to get arch properties from Triton side #590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR requires the change from Triton. We will update the pinned triton commit and re-trigger CI. Merge for now. |
|
CI check at #601 |
Stonepia
added a commit
that referenced
this pull request
Nov 7, 2024
Stonepia
added a commit
that referenced
this pull request
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we can get device architecture by sycl::device from 2024.1. https://github.com/intel/llvm/blob/b963e894678247d99b03f18d00ae7bdc4ca883da/sycl/include/sycl/ext/oneapi/experimental/device_architecture.hpp#L18 We are trying to get arch infomations from Triton side to decouple with IPEX. This may reduce the maintaining efforts. This is only for Triton testing now.