Dump address space types for LSC send messages

Dump address space types {private, global, local, generic, raystack} for LSC send messages in asm listing.
intel · Jul 11, 2023 · 2dfe380 · 2dfe380
1 parent 29f0166
commit 2dfe380
Show file tree

Hide file tree

Showing 3 changed files with 43 additions and 1 deletion.
diff --git a/IGC/Compiler/CISACodeGen/CISABuilder.cpp b/IGC/Compiler/CISACodeGen/CISABuilder.cpp
@@ -8074,6 +8074,8 @@ namespace IGC
  addr.immScale = 1;
  addr.immOffset = immOffset;
  addr.size = addr_size;
+ // TODO: update this accordingly
+ addr.addrSpace = LSC_DOC_ADDR_SPACE::INVALID;
 
  if (resource)
  {
@@ -8219,6 +8221,7 @@ namespace IGC
  addr.immScale = 1;
  addr.immOffset = immOffset;
  addr.size = addr_size;
+ addr.addrSpace = LSC_DOC_ADDR_SPACE::INVALID;
  if (resource)
  {
  addr.type = getLSCAddrType(resource);

diff --git a/visa/VisaToG4/TranslateSendLdStLsc.cpp b/visa/VisaToG4/TranslateSendLdStLsc.cpp
@@ -252,6 +252,31 @@ static int lscBlock2dComputeDataRegs(LSC_OP op,
  return dataRegs;
 }
 
+static std::string generateAddrSpaceComment(LSC_DOC_ADDR_SPACE addrSpace) {
+ std::string addrSpaceString = "";
+ switch (addrSpace) {
+ case LSC_DOC_ADDR_SPACE::PRIVATE:
+ addrSpaceString += "address space: private";
+ break;
+ case LSC_DOC_ADDR_SPACE::GLOBAL:
+ addrSpaceString += "address space: global";
+ break;
+ case LSC_DOC_ADDR_SPACE::LOCAL:
+ addrSpaceString += "addres space: local";
+ break;
+ case LSC_DOC_ADDR_SPACE::GENERIC:
+ addrSpaceString += "address space: generic";
+ break;
+ case LSC_DOC_ADDR_SPACE::RAYSTACK:
+ addrSpaceString += "address space: raystack";
+ break;
+ default:
+ // do not print anything
+ break;
+ }
+ return addrSpaceString;
+}
+
 int IR_Builder::translateLscUntypedInst(
  LSC_OP op, LSC_SFID lscSfid, G4_Predicate *pred,
  VISA_Exec_Size visaExecSize, VISA_EMask_Ctrl execCtrl,
@@ -621,9 +646,10 @@ int IR_Builder::translateLscUntypedInst(
  getSendAccessType(loadAccess, storeAccess),
  surface, LdStAttrs::NONE);
 
- createLscSendInst(pred, dstRead, src0Addr, src1Data, execSize, msgDesc,
+ auto sendInst = createLscSendInst(pred, dstRead, src0Addr, src1Data, execSize, msgDesc,
  instOpt, addrInfo.type, true);
 
+ sendInst->addComment(generateAddrSpaceComment(addrInfo.addrSpace));
  return status;
 }
 

diff --git a/visa/include/visa_igc_common_header.h b/visa/include/visa_igc_common_header.h
@@ -726,6 +726,15 @@ enum LSC_ADDR_TYPE {
  LSC_ADDR_TYPE_ARG, // pseudo address type for kernel arguments
 };
 
+enum class LSC_DOC_ADDR_SPACE {
+ INVALID,
+ PRIVATE,
+ GLOBAL,
+ LOCAL,
+ GENERIC,
+ RAYSTACK,
+};
+
 //
 // Caching override behavior
 //
@@ -780,6 +789,10 @@ struct LSC_ADDR {
 
  // The number of bits per address; not all address models support all sizes
  LSC_ADDR_SIZE size; // e.g. :a64, :a32, ...
+
+ // e.g private, global, local, generic, raystack
+ // used for documentation in comments
+ LSC_DOC_ADDR_SPACE addrSpace;
 };
 
 // The specific fence op