Code cleanup

Remove implementation of global split as feature has no line-of-sight to enable due to perf regressions.
intel · Jul 25, 2023 · 985b62d · 985b62d
1 parent 0c1367e
commit 985b62d
Show file tree

Hide file tree

Showing 18 changed files with 1,300 additions and 2,489 deletions.
diff --git a/visa/CMakeLists.txt b/visa/CMakeLists.txt
@@ -224,6 +224,7 @@ set(GenX_Common_Sources_External_Other
  CFGStructurizer.cpp
  Common_BinaryEncoding.cpp
  DebugInfo.cpp
+ RADebug.cpp
  FlagSpillCleanup.cpp
  FlowGraph.cpp
  G4_BB.cpp
@@ -321,6 +322,7 @@ set(GenX_Common_Headers
  Common_BinaryEncoding.h
  Common_GEN.h
  DebugInfo.h
+ RADebug.h
  FlagSpillCleanup.h
  FlowGraph.h
  G4_BB.hpp

diff --git a/visa/G4_Kernel.cpp b/visa/G4_Kernel.cpp
@@ -491,11 +491,6 @@ G4_Kernel::~G4_Kernel() {
  gtPinInfo.reset();
  }
 
- if (varSplitPass) {
- delete varSplitPass;
- varSplitPass = nullptr;
- }
-
  Declares.clear();
 }
 
@@ -924,15 +919,6 @@ std::string G4_Kernel::getDebugSrcLine(const std::string &fileName,
  return lines[srcLine - 1];
 }
 
-VarSplitPass *G4_Kernel::getVarSplitPass() {
- if (varSplitPass)
- return varSplitPass;
-
- varSplitPass = new VarSplitPass(*this);
-
- return varSplitPass;
-}
-
 unsigned G4_Kernel::getLargestInputRegister() {
  const unsigned inputCount = fg.builder->getInputCount();
  unsigned regNum = 0;

diff --git a/visa/G4_Kernel.hpp b/visa/G4_Kernel.hpp
@@ -425,7 +425,6 @@ class G4_Kernel {
 
  bool m_hasIndirectCall = false;
 
- VarSplitPass *varSplitPass = nullptr;
  GRFMode grfMode;
 
  // map key is filename string with complete path.
@@ -649,8 +648,6 @@ class G4_Kernel {
 
  std::string getDebugSrcLine(const std::string &filename, int lineNo);
 
- VarSplitPass *getVarSplitPass();
-
  VISATarget getKernelType() const { return kernelType; }
  void setKernelType(VISATarget t) { kernelType = t; }