Reset git tree after first yapf failure #230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have to run yapf twice because in a clean environment the first run most likely fails because of the race condition in yapf, see google/yapf#1164. If, however, the first run was successful and yapf has modified files, then we need to reset the changes, so the second run can detect them again. Note that the whole block (ignore the first run and reset the tree) will not be necessary and will be removed after fixed google/yapf#1164.
whitneywhtsang
approved these changes
Jan 10, 2024
ptillet
added a commit
to triton-lang/triton
that referenced
this pull request
Feb 2, 2024
binarman
pushed a commit
to binarman/triton
that referenced
this pull request
Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have to run yapf twice because in a clean environment the first run most likely fails because of the race condition in yapf, see google/yapf#1164. If, however, the first run was successful and yapf has modified files, then we need to reset the changes, so the second run can detect them again.
Note that the whole block (ignore the first run and reset the tree) will not be necessary and will be removed after fixed
google/yapf#1164.