-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BACKEND] Added sycl backend support #234
Conversation
Current error/failures look to me as environmental issues. @vlad-penkin @whitneywhtsang Can any of maintainer please confirm? |
It is no longer failing with
|
Test failures are due to change in function signature between ipex1.13 vs ipex2.0. We should at least move to ipex2.0 soon. |
#239 moves ipex to 2.1.10. |
@Sarbojit2019 Now that #239 is merged, please rebase your PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR needs some general cleanup, but I'd like us to explicitly articulate how we solve the problem and what are the next steps.
We bring in the sycl runtime, get the necessary handles from pytorch to queues, device, etc, and generate the same kernel/module via L0. Finally, we bundle the kernel into a "sycl program", create a sycl kernel and transfer the ownership to the sycl runtime. We then submit a sycl kernel to a sycl queue so that any consumer of the queue would be able to wait on the event in that queue (by querying outstanding events).
Could you please extend this with the phase 2 as you named it?
Also, a general question. Have we considered simply wrapping a level zero event handle into a sycl object and putting it into the queue? What is the downside of such an approach? In other words, why do we want to redo the launcher all everything instead? |
Signed-off-by: Tsang, Whitney <whitney.tsang@intel.com>
Signed-off-by: Tsang, Whitney <whitney.tsang@intel.com>
Signed-off-by: Tsang, Whitney <whitney.tsang@intel.com>
Signed-off-by: Whitney Tsang <whitney.tsang@intel.com>
[Phase-1]
There is a phase-2 change planed which will cleanup / remove level-zero codes.