[testing] Enable generating cached native code by default #2350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a bit of a hack, but I did not want to pollute build_flags with something that is not a real build_flag and there is no other way to pass params to loadBinary. We could probably duplicate loadBinary - I am considering that too, but for now the hack should let the tests run.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checking for functional correctness - we need to decide if this is something we're willing to do or if we want PyTorch to pass the cached native code flag for AOT inductor - and I'd like to wait to land this anyway until they have done some testing between systems, as there is some concern about native code portability (though I believe the SPIR-V is also bundled as part of the native code package)
Also, we will likely need better support for ocloc to detect the device architecture for the
-deviceflag.close #1792