Enable locality test #247
Merged
Enable locality test #247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etiotto
reviewed
Jan 15, 2024
alexbaden
force-pushed
the
alex/enable_test_locality
branch
from
55dcdcc to
fa1f53b
Compare
GENX fix is required to replace the unsupported opencl function call
alexbaden
force-pushed
the
alex/enable_test_locality
branch
from
fa1f53b to
c80e386
Compare
whitneywhtsang
approved these changes
Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables the locality test by using an IGC intrinsic instead of an OpenCL function for
get_global_size. IGC does not appear to support the OpenCL functionget_global_size, and SPIRV builtins are not currently an option. This PR uses intel/llvm#12383, resets the CI cache, and then simply removes the XPU skip fromtest_locality. Once thegenxbranch has been updated I will pop the tmp commit and rebase.Closes #154