[XPU][TritonIntelGPU] Fix issue in convert DotOp A layout to LinearLayout of DPAS. #2766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chengjunlu
commented
Nov 20, 2024
chengjunlu
force-pushed
the
chengjun/fix_dot_a_ll_cvt
branch
from
fbf9fc1 to
fb0efdf
Compare
chengjunlu
changed the title
jopperm
reviewed
Nov 20, 2024
third_party/intel/lib/Dialect/TritonIntelGPU/IR/LinearLayoutConversions.cpp
Outdated
Show resolved
Hide resolved
chengjunlu
force-pushed
the
chengjun/fix_dot_a_ll_cvt
branch
2 times, most recently
from
090d13e to
13ce636
Compare
chengjunlu
commented
Nov 21, 2024
| @@ -602,8 +614,7 @@ std::optional<LinearLayout> | |||
| dotOperandDpasToLinearLayout(DotOperandEncodingAttr dotDpasLayout, | |||
| ArrayRef<int64_t> shape) { | |||
| auto dpasLayout = cast<intel::DpasEncodingAttr>(dotDpasLayout.getParent()); | |||
| if (dotDpasLayout.getOpIdx() == 0) | |||
| return std::nullopt; | |||
|
|
|||
There was a problem hiding this comment.
Enable the DotOp A layout to LL layout conversion.
…nversions.cpp Co-authored-by: Julian Oppermann <julian.oppermann@codeplay.com>
jopperm
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code was using the old layout for DPAS operand A.
Update the code to the new layout which is supported by the OCL interface.