Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove test_emulated_atomics.py since float16 is tested in test_core.py #2906

Merged
merged 1 commit into from
Dec 3, 2024
Merged

Remove test_emulated_atomics.py since float16 is tested in test_core.py #2906

merged 1 commit into from
Dec 3, 2024

Conversation

anmyachev
Copy link
Contributor

@anmyachev anmyachev commented Dec 3, 2024 •
edited
Loading

Part of #2030

Namely here:

intel-xpu-backend-for-triton/python/test/unit/language/test_core.py

Line 1536 in 6588f0d

def test_tensor_atomic_rmw(shape, axis, num_ctas, dtype_x_str, device):

Initially was added in #760. At that time, float16 was not tested in test_core.py

@anmyachev
Remove 'test_emulated_atomics.py' since 'float16' is tested in 'test_…
4f17579 
…core.py'

Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
@anmyachev anmyachev marked this pull request as ready for review December 3, 2024 14:02
@anmyachev anmyachev merged commit 613ab8b into main Dec 3, 2024
5 checks passed
@anmyachev anmyachev deleted the amyachev/atomic_rmw branch December 3, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etiotto etiotto etiotto approved these changes

@whitneywhtsang whitneywhtsang Awaiting requested review from whitneywhtsang

@ienkovich ienkovich Awaiting requested review from ienkovich

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anmyachev @etiotto