[XPU][LLVMIR] Generate opencl.kernels named metadata
#2923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When converting `tt.func` to `llvm.func`, attach a `triton_gen.opencl_kernels` attribute to be handled during translation to LLVM IR. Then, add an `opencl.kernels` named metadata with `MDNodes` referencing kernel functions in the module. Signed-off-by: Victor Perez <victor.perez@codeplay.com>
|
Running https://github.com/intel/intel-xpu-backend-for-triton/actions/runs/12160033320/job/33911430010 for integration with #2845 and measuring performance impact of both PRs combined. |
I'm looking into it |
|
IGC compilation breaks only for given sub-group size-local size combination (16, 64). I'll fill a ticket in for that. |
|
Will hold this PR till IGC gets a fix. |
etiotto
reviewed
Dec 5, 2024
| handleTritonGenOpenCLKernelsAttr(Operation *op, | ||
| LLVM::ModuleTranslation &moduleTranslation) { | ||
| auto mlirFunc = dyn_cast<LLVM::LLVMFuncOp>(op); | ||
| if (!mlirFunc) |
There was a problem hiding this comment.
Shouldn't we also make sure the function is a kernel (with isKernel(op)) ?
There was a problem hiding this comment.
I'll look into that when I get back to this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When converting
tt.functollvm.func, attach atriton_gen.opencl_kernelsattribute to be handled during translation to LLVM IR. Then, add anopencl.kernelsnamed metadata withMDNodesreferencing kernel functions in the module.Closes #2869