[Windows] Enable instrumentation tests #3298
Merged
+39
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
anmyachev
commented
Jan 28, 2025
•
anmyachev
commented
- https://github.com/intel/intel-xpu-backend-for-triton/actions/runs/13056599095 (passed)
Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
anmyachev
commented
Jan 28, 2025
scripts/test-triton.sh
Outdated
| @@ -330,11 +330,12 @@ run_instrumentation_tests() { | |||
| fi | |||
|
|
|||
| INSTRUMENTATION_LIB_DIR=$(ls -1d $TRITON_PROJ/python/build/*lib*/triton/instrumentation) || err "Could not find $TRITON_PROJ/python/build/*lib*/triton/instrumentation, build Triton first" | |||
| INSTRUMENTATION_LIB_NAME=$(ls $INSTRUMENTATION_LIB_DIR/*GPUInstrumentationTestLib*) | |||
There was a problem hiding this comment.
For windows: GPUInstrumentationTestLib.dll
anmyachev
commented
Jan 28, 2025
Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
anmyachev
commented
Jan 29, 2025
| @@ -11,7 +11,7 @@ def is_xpu(): | |||
|
|
|||
| def _cc_cmd(cc, src, out, include_dirs, library_dirs, libraries): | |||
| if "cl.EXE" in cc or "clang-cl" in cc: | |||
| cc_cmd = [cc, "/Zc:__cplusplus", "/std:c++17", src, "/nologo", "/O2", "/LD"] | |||
| cc_cmd = [cc, "/Zc:__cplusplus", "/std:c++17", src, "/nologo", "/O2", "/LD", "/wd4996"] | |||
There was a problem hiding this comment.
To avoid receiving the following warnings in stderr (otherwise instrumentation\test_gpuhello.py::test_op doesn't work): sycl_functions.h:57:27: warning: \'getenv\' is deprecated: This function or variable may be unsafe. Consider using _dupenv_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [-Wdeprecated-declarations]
anmyachev
commented
Jan 29, 2025
| @@ -24,6 +24,8 @@ def _cc_cmd(cc, src, out, include_dirs, library_dirs, libraries): | |||
| cc_cmd = [cc, src, "-O3", "-shared", "-Wno-psabi"] | |||
| if os.name != "nt": | |||
| cc_cmd += ["-fPIC"] | |||
| else: | |||
| cc_cmd += ["-Wno-deprecated-declarations"] | |||
There was a problem hiding this comment.
The same, but for icpx.
anmyachev
commented
Jan 29, 2025
| @@ -99,3 +99,7 @@ PassPluginLibraryInfo getPassPluginInfo() { | |||
| extern "C" LLVM_ATTRIBUTE_WEAK PassPluginLibraryInfo llvmGetPassPluginInfo() { | |||
| return getPassPluginInfo(); | |||
| } | |||
|
|
|||
| #ifdef WIN32 | |||
| #pragma comment(linker, "/export:llvmGetPassPluginInfo") | |||
There was a problem hiding this comment.
The workaround since llvmGetPassPluginInfo doesn't have __declspec(dllexport) in its declaration .
__declspec(dllexport) was removed in llvm/llvm-project@5533357
pbchekin
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.