Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pip install bigdl #3245

Merged
merged 2 commits into from
Oct 26, 2021
Merged

Add pip install bigdl #3245

merged 2 commits into from
Oct 26, 2021

Conversation

shanyu-sys
Copy link
Contributor

Add empty bigdl packages with all bigdl packages (bigdl-orca, bigdl-nano, bigdl-chronos, bigdl-friesian, bigdl-serving) as install_requires. Note that I didn't explicitly added bigdl-dllib, bigdl-math, bigdl-tf, since they are already included in bigdl-orca install_requires

@shanyu-sys
Copy link
Contributor Author

Related issue #3195

python/setup.py Outdated
metadata = dict(
name='bigdl',
version=VERSION,
description='Seamlessly scale out TensorFlow and PyTorch for Big Data (using Spark & Ray)',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

description is not correct

@jason-dai
Copy link
Contributor

Need to update jenkins job to include it in the release job

@jason-dai
Copy link
Contributor

LGTM

@shanyu-sys
Copy link
Contributor Author

Need to update jenkins job to include it in the release job

Sure.

Besides, I have tested in local and it failed since bigdl-nano might not be included in our nightly release.

Shall we also add bigdl-nano to our combined release scripts (e.g release_default_linux_spark246)?

@jason-dai
Copy link
Contributor

Need to update jenkins job to include it in the release job

Sure.

Besides, I have tested in local and it failed since bigdl-nano might not be included in our nightly release.

Shall we also add bigdl-nano to our combined release scripts (e.g release_default_linux_spark246)?

Yes

@shanyu-sys
Copy link
Contributor Author

Need to update jenkins job to include it in the release job

Sure.
Besides, I have tested in local and it failed since bigdl-nano might not be included in our nightly release.
Shall we also add bigdl-nano to our combined release scripts (e.g release_default_linux_spark246)?

Yes

@leonardozcm is working on it. I will test again after bigdl-nano released.

@shanyu-sys
Copy link
Contributor Author

shanyu-sys commented Oct 26, 2021

Local test has passed. I will merge this PR first for public release, and test on Jenkins with released bigdl.

Below tasks will be done after release:

@shanyu-sys shanyu-sys merged commit 98f8c74 into intel:branch-2.0 Oct 26, 2021
@hkvision
Copy link
Contributor

One main issue remaining is how to uninstall? For install we can install everything by dependency, but when uninstall, it uninstalls nothing right?

@shanyu-sys
Copy link
Contributor Author

One main issue remaining is how to uninstall? For install we can install everything by dependency, but when uninstall, it uninstalls nothing right?

I haven't come up with a good idea. We could first provide a one-line command in the document for users
e.g.

pip uninstall bigdl-dllib bigdl-orca bigdl-chronos ...

The issue for pip for supporting pip uninstall dependencies is still open: pypa/pip#5823
An extra tool like pip3-autoremove could uninstall all the dependencies.
Or do you have better suggestions? It will also benefit uninstall for bigdl-orca

@shanyu-sys shanyu-sys deleted the bigdl-set-up branch October 27, 2021 02:13
@shanyu-sys
Copy link
Contributor Author

shanyu-sys commented Oct 27, 2021

Update:

  1. NB Jenkins job has been enabled with pip install --pre --upgrade bigdl, below jobs have been added and passed.
  1. bigdl whl has been released on pypi
  2. pip uninstall command has been added on user guide Change Analytics Zoo to BigDL in python user guide #3255

dding3 pushed a commit to dding3/BigDL that referenced this pull request Nov 17, 2021
* add pip install bigdl

* change description
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants