MediaControl: Dymically set mainline IVSC media-entity src-pad index #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since mainline kernel commit 48f5fd8967f8 ("media: ivsc: csi: Swap SINK
and SOURCE pads") the src-pad on the mainline ivsc mc-entity is pad 1,
where as on older versions it is pad 0.
When updating the sensor link to point to the IVSC instead, link.srcPad
was left at pad-0 inherited from the original sensor link.
Since with newer kernels this now needs to be pad-1, also update
link.srcPad and do so dynamically, so that it works with all mainline
IVSC driver versions.
This fixes ipu6-camera-hal / icamerasrc not working on laptops with
an IVSC chip running kernels using the mainline IVSC driver with
the mentioned commit.
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
|
Cc: @vicamo @smallorange (FYI) |
This is a duplicate of #112, no? |
Ah yes it looks like it is (#112 seems to do more, but it does also set link.srcPad like this PR does) . I did not see those changes because I was testing the main branch. Assuming that that commit is heading towards the main branch, then this can be closed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since mainline kernel commit 48f5fd8967f8 ("media: ivsc: csi: Swap SINK and SOURCE pads") the src-pad on the mainline ivsc mc-entity is pad 1, where as on older versions it is pad 0.
When updating the sensor link to point to the IVSC instead, link.srcPad was left at pad-0 inherited from the original sensor link.
Since with newer kernels this now needs to be pad-1, also update link.srcPad and do so dynamically, so that it works with all mainline IVSC driver versions.
This fixes ipu6-camera-hal / icamerasrc not working on laptops with an IVSC chip running kernels using the mainline IVSC driver with the mentioned commit.