Fixes for ppc64le unit tests #270
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lementation Follows the rest of the gf_vect_mul implementations for other architectures, and checks for size alignment, stated in the documentation. Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
|
@gerrith3, could you review this PR, which is fixing the unit tests for PowerPC? Thanks! |
gf_vect_mul_base is expected to work for all buffer sizes. However, this function is checking for size alignment to 32 bytes, to follow the other gf_vect_mul implementations. Therefore, another implementation for this function is included inside ppc64le folder to be used by the encoding functions. Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
pablodelara
force-pushed
the
pablodelara_fix_unit_tests_ec
branch
from
8f4a50b
to
f732ce1
Compare
|
Since there are no reviews and we have tested this fix works on a PPC container, this PR is merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some unit tests are currently failing, due to a missing check on the gf_vect_mul function (in ppc64le).
Also, because gf_vect_mul_base is used for encoding, in gf_vect_mul_vsx, which is used in encoding functions like gf_vect_dot_prod_vsx, it must be able to be called for any size. Hence, the implementation is added inside the ppc64le files, without such restriction.
Fixes #263