Fix macOS extended test (by using printf) #279
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To ensure #278 more, I needed to run extended test on macOS (both x64 and arm64) (https://github.com/cielavenir/isa-l/actions/runs/8130749368/job/22219331109 passed) |
|
can someone check this? |
pablodelara
reviewed
Mar 8, 2024
cielavenir
changed the title
|
There are three commits in this PR. Actually they can be merged into two commits. |
cielavenir
force-pushed
the
fixmacOSExtendedTest
branch
from
18b188e
to
92790f9
Compare
|
@liuqinfei rebased, though I'm not sure if I should rebase again after review, |
|
@cielavenir Looks ok, but could you change the name of the first commit to be more descriptive? Like "tools: replace echo -n with printf". I can do it for you if you like. |
Signed-off-by: Taiju Yamada <tyamada@bi.a.u-tokyo.ac.jp>
Signed-off-by: Taiju Yamada <tyamada@bi.a.u-tokyo.ac.jp>
cielavenir
force-pushed
the
fixmacOSExtendedTest
branch
from
92790f9
to
6262b96
Compare
|
@pablodelara rebased |
|
Code is merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because macOS's bash does not accept
echo -nwhen launched as /bin/sh