Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove large and unnecessary fortran objects #100

Merged
merged 2 commits into from
Oct 5, 2023
Merged

Remove large and unnecessary fortran objects #100

merged 2 commits into from
Oct 5, 2023

Conversation

Jake-Shadle
Copy link
Contributor

There are several precompiled fortran object files included in the rust package that are completely unnecessary, bloating the package.

abrown
abrown approved these changes Sep 16, 2023
View reviewed changes
Copy link
Contributor

@abrown abrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except for my comment about the .vscode exclude. I'll merge this once that gets re-added. Thanks for the contribution!

rust/ittapi-sys/Cargo.toml Show resolved Hide resolved
@abrown
Copy link
Contributor

abrown commented Sep 19, 2023

These CI failures have nothing to with the change; I opened #102 to fix this and then will merge this PR.

@abrown abrown merged commit 6036434 into intel:master Oct 5, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abrown abrown abrown approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jake-Shadle @abrown