Add compiler defenses flags - additional updates #162
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is essential to avoid buffer overflows and similar bugs as much as possible. Add AX_CHECK_LINK_FLAG macro usage witch requires `autoconf-archive` package to be installed. Add compiler flags: -D_FORTIFY_SOURCE - Compile-time protection against static sized buffer overflows, -fstack-protector-strong - Adds stack canaries to functions as safety checks against stack overwrites, -fPIE - Enables an ELF binary executable to be position independent, -fPIC - Ensures that shared object code that is built into shared libraries should be position independent code, so that the shared library can readily be loaded at any address in memory. Add linker flags: -pie - works together with gcc flag fPIE- please see its description, -z,relro - A security measure which makes some binary sections read-only, -z,now - Immediate Binding (Bindnow), -z,noexecstack - Prevents stack from being executable. Add 'autoconf-archive' package dependency to github workflows. This change is requied by githab actions. Fix compilation warnings. Signed-off-by: Pawel Piatkowski <pawel.piatkowski@intel.com>
This should be: -fno-delete-null-pointer-checks not -Wno-delete-null-pointer-checks. Signed-off-by: Tony Asleson <tasleson@redhat.com>
device_blink_behavior_set should not be public. Signed-off-by: Tony Asleson <tasleson@redhat.com>
Corrects warning from [-Wenum-int-mismatch] for const unsigned int mismatch with const enum led_ibpi_pattern. Signed-off-by: Tony Asleson <tasleson@redhat.com>
tasleson
force-pushed
the
compiler_defenses
branch
from
ecd8492
to
43915fc
Compare
tasleson
changed the title
|
I need to double verify how we should handle those flags. I'm not sure I they should be here. I need more time to check. Will do next week. |
|
Closing, will add a new PR after other PRs get merged if parts of this PR are still missing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR: #145 with some additional fixes.